From 965ecf322837f1071529079ae46533f605bb4c5b Mon Sep 17 00:00:00 2001 From: Alex Dunmow Date: Mon, 6 Jul 2026 16:07:14 +0800 Subject: [PATCH] fix(editorial): article H1, marginalia separator+contrast, home composition, SVG geometry guard MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit - article template now renders

{{ title }} once (was absent — title never showed) - marginalia anchor label is block-level foreground ink (was inline muted run-on) - landing lead top padding trimmed to close the dead band above the hero card - 22 icon-sprite SVGs carry explicit width/height (JIT balloon guard) Co-Authored-By: Claude Fable 5 --- blocks/marginalia.ninjatpl | 2 +- manifest.yaml | 18 ++++++++++++++++++ templates/editorial/article.ninjatpl | 3 ++- templates/editorial/landing.ninjatpl | 2 +- .../editorial/author-bio-hero.ninjatpl | 8 ++++---- .../overrides/editorial/contact-card.ninjatpl | 2 +- .../overrides/editorial/countdown.ninjatpl | 2 +- templates/overrides/editorial/cta.ninjatpl | 2 +- .../overrides/editorial/event-list.ninjatpl | 2 +- templates/overrides/editorial/faq.ninjatpl | 2 +- .../overrides/editorial/feature-grid.ninjatpl | 4 ++-- templates/overrides/editorial/pricing.ninjatpl | 2 +- .../overrides/editorial/rich-section.ninjatpl | 2 +- .../overrides/editorial/sidebar-nav.ninjatpl | 2 +- .../overrides/editorial/social-links.ninjatpl | 2 +- templates/overrides/editorial/team.ninjatpl | 2 +- .../overrides/editorial/testimonial.ninjatpl | 10 +++++----- .../overrides/editorial/timeline.ninjatpl | 2 +- 18 files changed, 44 insertions(+), 25 deletions(-) diff --git a/blocks/marginalia.ninjatpl b/blocks/marginalia.ninjatpl index f00b58c..53ef5f2 100644 --- a/blocks/marginalia.ninjatpl +++ b/blocks/marginalia.ninjatpl @@ -1 +1 @@ -
{% if items %}{% for note in items %}{% endfor %}{% else %}{% endif %}
+
{% if items %}{% for note in items %}{% endfor %}{% else %}{% endif %}
diff --git a/manifest.yaml b/manifest.yaml index 3f226d5..d2a81c4 100644 --- a/manifest.yaml +++ b/manifest.yaml @@ -384,6 +384,24 @@ css: opacity: 0; animation: editorial-fade-in 600ms ease forwards; } + /* Anchor label: block-level so it never runs into the note body, and + * foreground ink so it reads as a deliberate annotation heading. */ + .editorial-marginalia-label { + display: block; + margin-bottom: 0.4rem; + font-family: var(--font-body, "Inter", -apple-system, sans-serif); + font-style: normal; + font-weight: 600; + font-size: 0.68rem; + text-transform: uppercase; + letter-spacing: 0.12em; + color: hsl(var(--foreground)); + } + /* Note body: bump above muted-foreground for legibility in both modes. */ + .editorial-marginalia-note { + display: block; + color: hsl(var(--foreground) / 0.82); + } @keyframes editorial-fade-in { to { opacity: 1; } } @media (prefers-reduced-motion: reduce) { .editorial-marginalia aside { animation: none; opacity: 1; } diff --git a/templates/editorial/article.ninjatpl b/templates/editorial/article.ninjatpl index 38c5bf4..99d214d 100644 --- a/templates/editorial/article.ninjatpl +++ b/templates/editorial/article.ninjatpl @@ -5,7 +5,8 @@ {{ admin_banner_html|safe }} {% if slots.header %}
{{ slots.header|safe }}
{% endif %} - {% if slots.byline %}
{{ slots.byline|safe }}
{% endif %} + {% if title %}

{{ title }}

{% endif %} + {% if slots.byline %}
{{ slots.byline|safe }}
{% endif %}
{% if slots.main %}{{ slots.main|safe }}{% else %}

This essay has no content yet.

{% endif %}
diff --git a/templates/editorial/landing.ninjatpl b/templates/editorial/landing.ninjatpl index d6a3223..fc89c12 100644 --- a/templates/editorial/landing.ninjatpl +++ b/templates/editorial/landing.ninjatpl @@ -5,7 +5,7 @@ {{ admin_banner_html|safe }} {% if slots.masthead %}
{{ slots.masthead|safe }}
{% endif %}
- {% if slots.lead %}
{{ slots.lead|safe }}
{% endif %} + {% if slots.lead %}
{{ slots.lead|safe }}
{% endif %} {% if slots.river %}
{{ slots.river|safe }}
{% endif %}
{% if slots.footer %}
{{ slots.footer|safe }}
{% endif %} diff --git a/templates/overrides/editorial/author-bio-hero.ninjatpl b/templates/overrides/editorial/author-bio-hero.ninjatpl index b4fc060..78839c5 100644 --- a/templates/overrides/editorial/author-bio-hero.ninjatpl +++ b/templates/overrides/editorial/author-bio-hero.ninjatpl @@ -12,10 +12,10 @@ {% if author.location %}{{ author.location }}{% endif %}
{% if showSocial %}
-{% if author.website_url %}{% endif %} -{% if author.twitter_handle %}{% endif %} -{% if author.linkedin_url %}{% endif %} -{% if author.github_url %}{% endif %} +{% if author.website_url %}{% endif %} +{% if author.twitter_handle %}{% endif %} +{% if author.linkedin_url %}{% endif %} +{% if author.github_url %}{% endif %}
{% endif %} diff --git a/templates/overrides/editorial/contact-card.ninjatpl b/templates/overrides/editorial/contact-card.ninjatpl index b70de05..b28586d 100644 --- a/templates/overrides/editorial/contact-card.ninjatpl +++ b/templates/overrides/editorial/contact-card.ninjatpl @@ -5,7 +5,7 @@
{% for channel in channels %}
- {% if channel.icon %}{% endif %} + {% if channel.icon %}{% endif %}
{% if channel.label %}
{{ channel.label }}
{% endif %} {% if channel.value %}
{% if channel.link %}{{ channel.value }}{% else %}{{ channel.value }}{% endif %}
{% endif %} diff --git a/templates/overrides/editorial/countdown.ninjatpl b/templates/overrides/editorial/countdown.ninjatpl index 8d1f7e7..99c2bc9 100644 --- a/templates/overrides/editorial/countdown.ninjatpl +++ b/templates/overrides/editorial/countdown.ninjatpl @@ -11,7 +11,7 @@
diff --git a/templates/overrides/editorial/cta.ninjatpl b/templates/overrides/editorial/cta.ninjatpl index 12822f9..ead5ea9 100644 --- a/templates/overrides/editorial/cta.ninjatpl +++ b/templates/overrides/editorial/cta.ninjatpl @@ -6,7 +6,7 @@ {% if text %}

{{ text }}

{% endif %}
- {% if primaryUrl and primaryLabel %}{{ primaryLabel }}{% endif %} + {% if primaryUrl and primaryLabel %}{{ primaryLabel }}{% endif %} {% if secondaryUrl and secondaryLabel %}{{ secondaryLabel }}{% endif %}
diff --git a/templates/overrides/editorial/event-list.ninjatpl b/templates/overrides/editorial/event-list.ninjatpl index e5a6eec..bec0847 100644 --- a/templates/overrides/editorial/event-list.ninjatpl +++ b/templates/overrides/editorial/event-list.ninjatpl @@ -13,7 +13,7 @@

{{ event.title }}

{% if event.venue %}

{{ event.venue }}

{% endif %} {% if event.description %}

{{ event.description }}

{% endif %} - {% if event.link %}{{ event.linkLabel|default:"Details" }}{% endif %} + {% if event.link %}{{ event.linkLabel|default:"Details" }}{% endif %} {% endif %}{% endfor %} diff --git a/templates/overrides/editorial/faq.ninjatpl b/templates/overrides/editorial/faq.ninjatpl index 4bdd166..08da093 100644 --- a/templates/overrides/editorial/faq.ninjatpl +++ b/templates/overrides/editorial/faq.ninjatpl @@ -7,7 +7,7 @@
{{ item.question }} - +
{{ item.answer|safe }}
diff --git a/templates/overrides/editorial/feature-grid.ninjatpl b/templates/overrides/editorial/feature-grid.ninjatpl index 19d6ae2..757ab1e 100644 --- a/templates/overrides/editorial/feature-grid.ninjatpl +++ b/templates/overrides/editorial/feature-grid.ninjatpl @@ -6,10 +6,10 @@
{% for item in items %}
- {% if item.icon %}
{% endif %} + {% if item.icon %}
{% endif %}

{% if item.linkUrl %}{{ item.title }}{% else %}{{ item.title }}{% endif %}

{% if item.text %}

{{ item.text }}

{% endif %} - {% if item.linkUrl and item.linkLabel %}{{ item.linkLabel }}{% endif %} + {% if item.linkUrl and item.linkLabel %}{{ item.linkLabel }}{% endif %}
{% endfor %}
diff --git a/templates/overrides/editorial/pricing.ninjatpl b/templates/overrides/editorial/pricing.ninjatpl index d7bc788..4d404a0 100644 --- a/templates/overrides/editorial/pricing.ninjatpl +++ b/templates/overrides/editorial/pricing.ninjatpl @@ -14,7 +14,7 @@

{% if tier.description %}

{{ tier.description }}

{% endif %} {% if tier.features %}
    - {% for feature in tier.features %}
  • {{ feature }}
    • {% endfor %} + {% for feature in tier.features %}
  • {{ feature }}
    • {% endfor %}
{% endif %} {% if tier.ctaUrl and tier.ctaLabel %}{% if tier.highlighted %}{{ tier.ctaLabel }}{% else %}{{ tier.ctaLabel }}{% endif %}{% endif %} diff --git a/templates/overrides/editorial/rich-section.ninjatpl b/templates/overrides/editorial/rich-section.ninjatpl index 77f56aa..1be3e52 100644 --- a/templates/overrides/editorial/rich-section.ninjatpl +++ b/templates/overrides/editorial/rich-section.ninjatpl @@ -4,7 +4,7 @@ {% if eyebrow %}

{{ eyebrow }}

{% endif %} {% if heading %}

{{ heading }}

{% endif %} {% if body %}
{{ body|safe }}
{% endif %} - {% if ctaUrl and ctaLabel %}{{ ctaLabel }}{% endif %} + {% if ctaUrl and ctaLabel %}{{ ctaLabel }}{% endif %}
{% if media %}
{% img media alt=mediaAlt class="w-full h-auto object-cover" %}
{% endif %} diff --git a/templates/overrides/editorial/sidebar-nav.ninjatpl b/templates/overrides/editorial/sidebar-nav.ninjatpl index 800c4dc..bb9e93b 100644 --- a/templates/overrides/editorial/sidebar-nav.ninjatpl +++ b/templates/overrides/editorial/sidebar-nav.ninjatpl @@ -4,7 +4,7 @@ {% if title %}

{{ title }}

{% endif %} diff --git a/templates/overrides/editorial/social-links.ninjatpl b/templates/overrides/editorial/social-links.ninjatpl index c5998c6..41fbbb3 100644 --- a/templates/overrides/editorial/social-links.ninjatpl +++ b/templates/overrides/editorial/social-links.ninjatpl @@ -4,7 +4,7 @@ {% for link in links %}{% if link.url %}
  • - {% if link.network %}{% endif %} + {% if link.network %}{% endif %} {% if style == "stack" and link.label %}{{ link.label }}{% endif %}
    • diff --git a/templates/overrides/editorial/team.ninjatpl b/templates/overrides/editorial/team.ninjatpl index 86cec2a..31fcc93 100644 --- a/templates/overrides/editorial/team.ninjatpl +++ b/templates/overrides/editorial/team.ninjatpl @@ -11,7 +11,7 @@ {% if member.role %}

    {{ member.role }}

    {% endif %} {% if member.bio %}

    {{ member.bio }}

    {% endif %} {% if member.socials %}
    - {% for social in member.socials %}{% if social.url %}{% endif %}{% endfor %} + {% for social in member.socials %}{% if social.url %}{% endif %}{% endfor %}
    {% endif %}
    diff --git a/templates/overrides/editorial/testimonial.ninjatpl b/templates/overrides/editorial/testimonial.ninjatpl index fbc6829..5d573ff 100644 --- a/templates/overrides/editorial/testimonial.ninjatpl +++ b/templates/overrides/editorial/testimonial.ninjatpl @@ -5,11 +5,11 @@ {% for q in quotes %}
    {% if q.rating %}
    - - - - - + + + + +
    {% endif %}
    {% if q.quote %}“{{ q.quote }}”{% endif %}
    diff --git a/templates/overrides/editorial/timeline.ninjatpl b/templates/overrides/editorial/timeline.ninjatpl index 6d05a05..bf01faf 100644 --- a/templates/overrides/editorial/timeline.ninjatpl +++ b/templates/overrides/editorial/timeline.ninjatpl @@ -6,7 +6,7 @@ {% for step in steps %}
  • - {% if marker == "numbered" %}{{ forloop.counter }}{% elif marker == "dot" %}{% else %}{% endif %} + {% if marker == "numbered" %}{{ forloop.counter }}{% elif marker == "dot" %}{% else %}{% endif %}
    {% if step.label %}

    {{ step.label }}

    {% endif %}