40ba4ee9de
Close three WO-WZ-004 review gaps in the guest db driver: - toDbValue: nil []string now marshals to DbValue_Null (matching []byte / json.RawMessage); empty-but-non-nil stays a non-NULL empty text[]. - DbValueFixtures: add edge entries (zero time.Time, negative + very-large numeric strings, empty text[], and text[] elements forcing encodePgTextArray quoting/escaping). Covered automatically by the table-driven round-trip and driver-value tests; new dbvalue_test.go covers the toDbValue nil convention. - Document that TextArray cannot represent a NULL array element (repeated string has no per-element NULL) in the fixtures file and docs/wasm-abi.md, a contract limit the WO-WZ-007 host executor must also honor. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
76 lines
2.1 KiB
Go
76 lines
2.1 KiB
Go
package bnwasm
|
|
|
|
import (
|
|
"encoding/json"
|
|
"reflect"
|
|
"testing"
|
|
|
|
abiv1 "git.dev.alexdunmow.com/block/core/abi/v1"
|
|
)
|
|
|
|
// TestToDbValueTextArrayNilVsEmpty pins the guest-side arg encoding for []string:
|
|
// a nil slice marshals to SQL NULL (matching []byte/json.RawMessage), while an
|
|
// empty-but-non-nil slice stays a non-NULL empty text[]. WO-WZ-007's host must
|
|
// mirror this nil→NULL convention.
|
|
func TestToDbValueTextArrayNilVsEmpty(t *testing.T) {
|
|
t.Run("nil", func(t *testing.T) {
|
|
dv, err := toDbValue([]string(nil))
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
if _, ok := dv.GetKind().(*abiv1.DbValue_Null); !ok {
|
|
t.Fatalf("nil []string: want DbValue_Null, got %T", dv.GetKind())
|
|
}
|
|
})
|
|
t.Run("empty", func(t *testing.T) {
|
|
dv, err := toDbValue([]string{})
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
ta, ok := dv.GetKind().(*abiv1.DbValue_TextArrayValue)
|
|
if !ok {
|
|
t.Fatalf("empty []string: want DbValue_TextArrayValue, got %T", dv.GetKind())
|
|
}
|
|
if got := ta.TextArrayValue.GetValues(); len(got) != 0 {
|
|
t.Fatalf("empty []string: want zero-length text[], got %#v", got)
|
|
}
|
|
})
|
|
t.Run("values", func(t *testing.T) {
|
|
dv, err := toDbValue([]string{"a", "b"})
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
ta, ok := dv.GetKind().(*abiv1.DbValue_TextArrayValue)
|
|
if !ok {
|
|
t.Fatalf("want DbValue_TextArrayValue, got %T", dv.GetKind())
|
|
}
|
|
if got := ta.TextArrayValue.GetValues(); !reflect.DeepEqual(got, []string{"a", "b"}) {
|
|
t.Fatalf("want [a b], got %#v", got)
|
|
}
|
|
})
|
|
}
|
|
|
|
// TestToDbValueNilConvention locks the nil→NULL convention across the reference
|
|
// types so []string stays consistent with []byte and json.RawMessage.
|
|
func TestToDbValueNilConvention(t *testing.T) {
|
|
cases := []struct {
|
|
name string
|
|
in any
|
|
}{
|
|
{"bytes", []byte(nil)},
|
|
{"json", json.RawMessage(nil)},
|
|
{"text_array", []string(nil)},
|
|
}
|
|
for _, c := range cases {
|
|
t.Run(c.name, func(t *testing.T) {
|
|
dv, err := toDbValue(c.in)
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
if _, ok := dv.GetKind().(*abiv1.DbValue_Null); !ok {
|
|
t.Fatalf("nil %s: want DbValue_Null, got %T", c.name, dv.GetKind())
|
|
}
|
|
})
|
|
}
|
|
}
|