block/cli
Template
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

chore(theme): modernize strings.Split to SplitSeq

Browse Source 
Convert two loops in the theme command from strings.Split() to
strings.SplitSeq() for more efficient iteration using Go 1.24+ iterators.
This is a mechanical modernization with identical behavior.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This commit is contained in:
Alex Dunmow 2026-07-07 12:46:02 +08:00
parent 42789ffd0f
commit f074d71cf9
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
cmd/ninja/cmd/theme.go
View File

@ -115,7 +115,7 @@ the rest of the CLI.`,
return fmt.Errorf("create %s: %w", screenshotsDir, err) return fmt.Errorf("create %s: %w", screenshotsDir, err)
} }
n := 0 n := 0
for _, pageSlug := range strings.Split(pages, ",") { for pageSlug := range strings.SplitSeq(pages, ",") {
pageSlug = strings.TrimSpace(pageSlug) pageSlug = strings.TrimSpace(pageSlug)
if pageSlug == "" { if pageSlug == "" {
continue continue
@ -176,7 +176,7 @@ func parseModes(modes string) ([]string, error) {
return []string{""}, nil return []string{""}, nil
} }
var out []string var out []string
for _, m := range strings.Split(modes, ",") { for m := range strings.SplitSeq(modes, ",") {
m = strings.TrimSpace(m) m = strings.TrimSpace(m)
if m != "light" && m != "dark" { if m != "light" && m != "dark" {
return nil, fmt.Errorf("--modes: %q is not a valid mode (want light or dark)", m) return nil, fmt.Errorf("--modes: %q is not a valid mode (want light or dark)", m)