Static safety/lint runner for the BlockNinja codebase. ~25 invariant
checks across Go and frontend sources. Was at git.dev.alexdunmow.com:block/ninja
in backend/cmd/check-safety/ until the 2026-06-06 consolidation moved
the BlockNinja repos under a shared ~/src/blockninja/ parent.
This repo is the standalone extraction:
- Own go.mod (git.dev.alexdunmow.com/block/check-safety, go 1.26.4)
- Vendored internal/{helpers,theme} from CMS (Go's internal/ rule
blocks cross-module imports; vendoring is the workaround)
- CLI contract unchanged: `check-safety <target-dir> [--flags]`
- CMS Makefile shells into ../check-safety for safety-check /
install-safety-checker targets
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
105 lines
3.0 KiB
Go
105 lines
3.0 KiB
Go
package main
|
|
|
|
import (
|
|
"path/filepath"
|
|
"strings"
|
|
"testing"
|
|
)
|
|
|
|
func TestCheckCMSCoreSDKGoModFlagsLocalBlockCoreReplace(t *testing.T) {
|
|
root := t.TempDir()
|
|
writeTestFile(t, filepath.Join(root, "go.mod"), `module git.dev.alexdunmow.com/block/ninja
|
|
|
|
go 1.26.2
|
|
|
|
require git.dev.alexdunmow.com/block/core v0.5.0
|
|
|
|
replace git.dev.alexdunmow.com/block/core => ../core
|
|
`, 0644)
|
|
|
|
violations := checkCMSCoreSDKGoMod(root)
|
|
if len(violations) != 1 {
|
|
t.Fatalf("checkCMSCoreSDKGoMod() returned %d violations, want 1: %#v", len(violations), violations)
|
|
}
|
|
if violations[0].rule != "no-local-block-core-replace" {
|
|
t.Fatalf("rule = %q, want no-local-block-core-replace", violations[0].rule)
|
|
}
|
|
if violations[0].line != 7 {
|
|
t.Fatalf("line = %d, want 7", violations[0].line)
|
|
}
|
|
}
|
|
|
|
func TestCheckCMSCoreSDKGoModAllowsPublishedBlockCoreRequire(t *testing.T) {
|
|
root := t.TempDir()
|
|
writeTestFile(t, filepath.Join(root, "go.mod"), `module git.dev.alexdunmow.com/block/ninja
|
|
|
|
go 1.26.2
|
|
|
|
require git.dev.alexdunmow.com/block/core v0.5.0
|
|
`, 0644)
|
|
|
|
violations := checkCMSCoreSDKGoMod(root)
|
|
if len(violations) != 0 {
|
|
t.Fatalf("checkCMSCoreSDKGoMod() returned %d violations, want 0: %#v", len(violations), violations)
|
|
}
|
|
}
|
|
|
|
func TestCheckStandalonePluginGoModFlagsReplaceDirectives(t *testing.T) {
|
|
root := t.TempDir()
|
|
writeTestFile(t, filepath.Join(root, "go.mod"), `module example.com/plugin
|
|
|
|
go 1.26.2
|
|
|
|
require git.dev.alexdunmow.com/block/core v0.2.1
|
|
|
|
replace git.dev.alexdunmow.com/block/core => ../block-core
|
|
`, 0644)
|
|
|
|
violations := checkStandalonePluginGoMod(root, "v0.2.1")
|
|
if len(violations) != 1 {
|
|
t.Fatalf("checkStandalonePluginGoMod() returned %d violations, want 1: %#v", len(violations), violations)
|
|
}
|
|
if violations[0].rule != "no-replace-directives" {
|
|
t.Fatalf("rule = %q, want no-replace-directives", violations[0].rule)
|
|
}
|
|
if violations[0].line != 7 {
|
|
t.Fatalf("line = %d, want 7", violations[0].line)
|
|
}
|
|
}
|
|
|
|
func TestCheckStandalonePluginGoModFlagsOutdatedSDKVersion(t *testing.T) {
|
|
root := t.TempDir()
|
|
writeTestFile(t, filepath.Join(root, "go.mod"), `module example.com/plugin
|
|
|
|
go 1.26.2
|
|
|
|
require git.dev.alexdunmow.com/block/core v0.2.0
|
|
`, 0644)
|
|
|
|
violations := checkStandalonePluginGoMod(root, "v0.2.1")
|
|
if len(violations) != 1 {
|
|
t.Fatalf("checkStandalonePluginGoMod() returned %d violations, want 1: %#v", len(violations), violations)
|
|
}
|
|
if violations[0].rule != "block-core-version-mismatch" {
|
|
t.Fatalf("rule = %q, want block-core-version-mismatch", violations[0].rule)
|
|
}
|
|
if !strings.Contains(violations[0].detail, "want v0.2.1") {
|
|
t.Fatalf("detail = %q, want target version", violations[0].detail)
|
|
}
|
|
}
|
|
|
|
func TestCheckStandalonePluginGoModAllowsMatchingSDKVersionWithoutReplace(t *testing.T) {
|
|
root := t.TempDir()
|
|
writeTestFile(t, filepath.Join(root, "go.mod"), `module example.com/plugin
|
|
|
|
go 1.26.2
|
|
|
|
require git.dev.alexdunmow.com/block/core v0.2.1
|
|
`, 0644)
|
|
|
|
violations := checkStandalonePluginGoMod(root, "v0.2.1")
|
|
if len(violations) != 0 {
|
|
t.Fatalf("checkStandalonePluginGoMod() returned %d violations, want 0: %#v", len(violations), violations)
|
|
}
|
|
}
|