check-safety/check_todos.go
Alex Dunmow cd88c808b0 initial: standalone check-safety module hoisted from CMS
Static safety/lint runner for the BlockNinja codebase. ~25 invariant
checks across Go and frontend sources. Was at git.dev.alexdunmow.com:block/ninja
in backend/cmd/check-safety/ until the 2026-06-06 consolidation moved
the BlockNinja repos under a shared ~/src/blockninja/ parent.

This repo is the standalone extraction:
- Own go.mod (git.dev.alexdunmow.com/block/check-safety, go 1.26.4)
- Vendored internal/{helpers,theme} from CMS (Go's internal/ rule
  blocks cross-module imports; vendoring is the workaround)
- CLI contract unchanged: `check-safety <target-dir> [--flags]`
- CMS Makefile shells into ../check-safety for safety-check /
  install-safety-checker targets

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
2026-06-06 13:04:02 +08:00

49 lines
1.5 KiB
Go

package main
import "fmt"
func init() {
register(Check{
Seq: 170,
ID: "17",
Title: "No TODO markers in production code",
Run: func(ctx *ScanContext, rep *Reporter) {
// Check 17: No TODO markers in production code
fmt.Println("=== Check 17: No TODO markers in production code ===")
todoRoots := make([]todoScanRoot, 0, len(ctx.backendTargets)+len(ctx.frontendTargets)+len(ctx.pluginTargets))
for _, target := range ctx.backendTargets {
todoRoots = append(todoRoots, todoScanRoot{
root: target.root,
displayPrefix: target.display,
})
}
for _, target := range ctx.frontendTargets {
todoRoots = append(todoRoots, todoScanRoot{
root: target.dir,
displayPrefix: target.label,
})
}
for _, target := range ctx.pluginTargets {
todoRoots = append(todoRoots, todoScanRoot{
root: target.root,
displayPrefix: target.display,
})
}
todoViolations := checkTODOs(todoRoots)
if len(todoViolations) > 0 {
fmt.Printf(" FAIL: %d TODO marker(s) found:\n", len(todoViolations))
for _, v := range todoViolations {
fmt.Printf(" %s:%d %s\n", v.file, v.line, v.snippet)
}
fmt.Println("\n Fix: Remove TODO markers and ship explicit behavior instead of placeholders.")
rep.Fail()
} else {
fmt.Println(" OK: No TODO markers found in production code")
printPerTargetOKLines(pluginTargetLabels(ctx.pluginTargets))
}
fmt.Println()
},
})
}