cd88c808b0
Static safety/lint runner for the BlockNinja codebase. ~25 invariant
checks across Go and frontend sources. Was at git.dev.alexdunmow.com:block/ninja
in backend/cmd/check-safety/ until the 2026-06-06 consolidation moved
the BlockNinja repos under a shared ~/src/blockninja/ parent.
This repo is the standalone extraction:
- Own go.mod (git.dev.alexdunmow.com/block/check-safety, go 1.26.4)
- Vendored internal/{helpers,theme} from CMS (Go's internal/ rule
blocks cross-module imports; vendoring is the workaround)
- CLI contract unchanged: `check-safety <target-dir> [--flags]`
- CMS Makefile shells into ../check-safety for safety-check /
install-safety-checker targets
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
42 lines
1.3 KiB
Go
42 lines
1.3 KiB
Go
package main
|
|
|
|
import "fmt"
|
|
|
|
func init() {
|
|
register(Check{
|
|
Seq: 150,
|
|
ID: "15",
|
|
Title: "No err.Error() leaked to HTTP clients",
|
|
Run: func(ctx *ScanContext, rep *Reporter) {
|
|
// Check 15: No err.Error() leaked to HTTP clients
|
|
fmt.Println("=== Check 15: No err.Error() leaked to HTTP clients ===")
|
|
var errLeaks []errLeakViolation
|
|
for _, target := range ctx.backendTargets {
|
|
for _, v := range checkErrLeak(target.root) {
|
|
v.file = prefixDisplayPath(target.display, v.file)
|
|
errLeaks = append(errLeaks, v)
|
|
}
|
|
}
|
|
for _, target := range ctx.pluginTargets {
|
|
for _, v := range checkErrLeak(target.root) {
|
|
v.file = prefixDisplayPath(target.display, v.file)
|
|
errLeaks = append(errLeaks, v)
|
|
}
|
|
}
|
|
if len(errLeaks) > 0 {
|
|
fmt.Printf(" FAIL: %d err.Error() leak(s) to HTTP clients:\n", len(errLeaks))
|
|
for _, v := range errLeaks {
|
|
fmt.Printf(" %s:%d %s\n", v.file, v.line, v.snippet)
|
|
}
|
|
fmt.Println("\n Fix: Log the error with slog.Error() and return a user-friendly message: http.Error(w, \"failed to open repository\", status)")
|
|
rep.Fail()
|
|
} else {
|
|
fmt.Println(" OK: No err.Error() leaked to HTTP clients")
|
|
printPerTargetOKLines(pluginTargetLabels(ctx.pluginTargets))
|
|
}
|
|
|
|
fmt.Println()
|
|
},
|
|
})
|
|
}
|