c4d01de82c
Reporter is now a collector: checks declare a verdict (OK/Skip/Warn/Fail/ Fatal) plus findings, and a single central render() prints output. Default output is silent on pass/skip — only FAIL/WARN/ERR checks print, followed by one tally line, so a clean run is two lines. --verbose restores full per-check output. All ~30 checks were converted to this API; orphaned guidance/label helpers (printPerTargetOKLines, per-check *Help blocks, colors_format.go) were removed. The any-usage check (2e) now defaults to only the unstaged working-tree diff (changed lines), via a new per-repo git-diff index in changedlines.go; --all-any restores the full scan. Not-a-git-repo / no-diff warns on nothing. Golden fixtures regenerated; integration tests updated to the new format; added unit tests for the diff index. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
40 lines
1.1 KiB
Go
40 lines
1.1 KiB
Go
package main
|
|
|
|
func init() {
|
|
register(Check{
|
|
Seq: 170,
|
|
ID: "17",
|
|
Title: "No TODO markers in production code",
|
|
Run: func(ctx *ScanContext, rep *Reporter) {
|
|
todoRoots := make([]todoScanRoot, 0, len(ctx.backendTargets)+len(ctx.frontendTargets)+len(ctx.pluginTargets))
|
|
for _, target := range ctx.backendTargets {
|
|
todoRoots = append(todoRoots, todoScanRoot{
|
|
root: target.root,
|
|
displayPrefix: target.display,
|
|
})
|
|
}
|
|
for _, target := range ctx.frontendTargets {
|
|
todoRoots = append(todoRoots, todoScanRoot{
|
|
root: target.dir,
|
|
displayPrefix: target.label,
|
|
})
|
|
}
|
|
for _, target := range ctx.pluginTargets {
|
|
todoRoots = append(todoRoots, todoScanRoot{
|
|
root: target.root,
|
|
displayPrefix: target.display,
|
|
})
|
|
}
|
|
todoViolations := checkTODOs(todoRoots)
|
|
if len(todoViolations) > 0 {
|
|
rep.Fail("%d TODO marker(s) found — ship explicit behavior, not placeholders", len(todoViolations))
|
|
for _, v := range todoViolations {
|
|
rep.Findingf("%s:%d %s", v.file, v.line, v.snippet)
|
|
}
|
|
} else {
|
|
rep.OK("No TODO markers found in production code")
|
|
}
|
|
},
|
|
})
|
|
}
|