c4d01de82c
Reporter is now a collector: checks declare a verdict (OK/Skip/Warn/Fail/ Fatal) plus findings, and a single central render() prints output. Default output is silent on pass/skip — only FAIL/WARN/ERR checks print, followed by one tally line, so a clean run is two lines. --verbose restores full per-check output. All ~30 checks were converted to this API; orphaned guidance/label helpers (printPerTargetOKLines, per-check *Help blocks, colors_format.go) were removed. The any-usage check (2e) now defaults to only the unstaged working-tree diff (changed lines), via a new per-repo git-diff index in changedlines.go; --all-any restores the full scan. Not-a-git-repo / no-diff warns on nothing. Golden fixtures regenerated; integration tests updated to the new format; added unit tests for the diff index. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
43 lines
1.3 KiB
Go
43 lines
1.3 KiB
Go
package main
|
|
|
|
func init() {
|
|
register(Check{
|
|
Seq: 130,
|
|
ID: "13",
|
|
Title: "RPC query/mutation error handling",
|
|
Run: func(ctx *ScanContext, rep *Reporter) {
|
|
if len(ctx.frontendTargets) > 0 {
|
|
var rpcViolations []rpcErrorViolation
|
|
var rpcWarnings []rpcErrorViolation
|
|
for _, target := range ctx.frontendTargets {
|
|
pv, pw := checkRPCErrors(target.dir)
|
|
for _, v := range pv {
|
|
v.file = prefixDisplayPath(target.label, v.file)
|
|
rpcViolations = append(rpcViolations, v)
|
|
}
|
|
for _, w := range pw {
|
|
w.file = prefixDisplayPath(target.label, w.file)
|
|
rpcWarnings = append(rpcWarnings, w)
|
|
}
|
|
}
|
|
|
|
if len(rpcViolations) > 0 {
|
|
rep.Fail("%d mutation(s) with no error handling", len(rpcViolations))
|
|
for _, v := range rpcViolations {
|
|
rep.Findingf("%s:%d [%s] %s", v.file, v.line, v.rule, v.snippet)
|
|
}
|
|
if len(rpcWarnings) > 0 {
|
|
rep.Findingf("%d useQuery call(s) without error destructuring (global handler covers these)", len(rpcWarnings))
|
|
}
|
|
} else if len(rpcWarnings) > 0 {
|
|
rep.OK("All mutations have error handling (%d queries rely on global error handler)", len(rpcWarnings))
|
|
} else {
|
|
rep.OK("All mutations have error handling")
|
|
}
|
|
} else {
|
|
rep.Skip("no frontend sources found")
|
|
}
|
|
},
|
|
})
|
|
}
|