check-safety/check_eslintdirective.go
Alex Dunmow c4d01de82c feat: concise output + diff-scoped any check
Reporter is now a collector: checks declare a verdict (OK/Skip/Warn/Fail/
Fatal) plus findings, and a single central render() prints output. Default
output is silent on pass/skip — only FAIL/WARN/ERR checks print, followed by
one tally line, so a clean run is two lines. --verbose restores full per-check
output. All ~30 checks were converted to this API; orphaned guidance/label
helpers (printPerTargetOKLines, per-check *Help blocks, colors_format.go) were
removed.

The any-usage check (2e) now defaults to only the unstaged working-tree diff
(changed lines), via a new per-repo git-diff index in changedlines.go; --all-any
restores the full scan. Not-a-git-repo / no-diff warns on nothing.

Golden fixtures regenerated; integration tests updated to the new format; added
unit tests for the diff index.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
2026-07-04 01:16:56 +08:00

32 lines
1.0 KiB
Go

package main
func init() {
register(Check{
Seq: 106,
ID: "10b",
Title: "No eslint-disable-next-line comments",
Run: func(ctx *ScanContext, rep *Reporter) {
eslintDirectiveTargets := collectESLintDirectiveTargets(ctx.repoRoot, ctx.frontendTargets)
if len(eslintDirectiveTargets) > 0 {
var directiveViolations []eslintDirectiveViolation
for _, target := range eslintDirectiveTargets {
for _, v := range checkESLintDisableNextLine(target.dir) {
v.file = prefixDisplayPath(target.label, v.file)
directiveViolations = append(directiveViolations, v)
}
}
if len(directiveViolations) > 0 {
rep.Fail("%d eslint-disable-next-line comment(s) found — rewrite the code or typing so the directive is unnecessary", len(directiveViolations))
for _, v := range directiveViolations {
rep.Findingf("%s:%d %s", v.file, v.line, v.snippet)
}
} else {
rep.OK("No eslint-disable-next-line comments found")
}
} else {
rep.Skip("no frontend sources found")
}
},
})
}